From 54d94e9e1a61f89058b0a0af6e3884da62c4f920 Mon Sep 17 00:00:00 2001 From: "Laetitia (O-01-67)" <68935009+O-01-67@users.noreply.github.com> Date: Mon, 27 Feb 2023 15:35:36 -0500 Subject: [PATCH] fix bug with dye registering as an undefined element --- mods/maxColorOffset.js | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/mods/maxColorOffset.js b/mods/maxColorOffset.js index 70925382..d3f75cb3 100644 --- a/mods/maxColorOffset.js +++ b/mods/maxColorOffset.js @@ -1,3 +1,5 @@ +defaultColorOffset = 15; + pixelColorPick = function(pixel,customColor=null,maxOffset=null) { var element = pixel.element; var elementInfo = elements[element]; @@ -24,7 +26,12 @@ pixelColorPick = function(pixel,customColor=null,maxOffset=null) { } // Randomly darken or lighten the RGB color //try maxOffset parameter, then info maxColorOffset, then default 15 - var offsetAmount = (maxOffset == null ? (elementInfo.maxColorOffset == undefined ? 15 : elementInfo.maxColorOffset) : maxOffset); + var offsetAmount; + if(maxOffset !== null) { + offsetAmount = maxOffset; + } else { + offsetAmount = elementInfo?.maxColorOffset ?? defaultColorOffset; + }; var maxColorOffset = Math.floor(Math.random() * (Math.random() > 0.5 ? -1 : 1) * Math.random() * offsetAmount); var r = rgb.r + maxColorOffset;